search

Kong / go-database-reconciler

Apache License 2.0
5 stars 3 forks source link

fix: do not fetch oauth2 from konnect #128

Closed czeslavo closed 1 month ago

czeslavo commented 1 month ago

Summary

As Konnect does not support OAuth2 credentials, we should not try to fetch them when dumping config (currently it returns 404s that are ignored).

Issues resolved

Part of https://github.com/Kong/kubernetes-ingress-controller/issues/6240.

CLAassistant commented 1 month ago

CLA assistant check
All committers have signed the CLA.

codecov-commenter commented 1 month ago

Codecov Report

Attention: Patch coverage is 20.00000% with 12 lines in your changes missing coverage. Please review.

Project coverage is 42.72%. Comparing base (8de497a) to head (7e362ad). Report is 1 commits behind head on main.

Files Patch % Lines
pkg/dump/dump.go 0.00% 7 Missing :warning:
pkg/utils/types.go 0.00% 4 Missing :warning:
pkg/file/writer.go 0.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #128 +/- ## ========================================== - Coverage 42.72% 42.72% -0.01% ========================================== Files 75 75 Lines 8819 8820 +1 ========================================== Hits 3768 3768 - Misses 4587 4588 +1 Partials 464 464 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.