Closed samugi closed 1 month ago
Attention: Patch coverage is 0%
with 15 lines
in your changes missing coverage. Please review.
Project coverage is 42.78%. Comparing base (
64dd801
) to head (decf4d3
).
Files | Patch % | Lines |
---|---|---|
pkg/diff/diff.go | 0.00% | 15 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Does this change make the filling defaults only run for
diff
printing differences but not tosync
really updating configuration?
Correct @randmonkey , I added examples of how the change affects deck in the PR description.
Would this approach still require changes in Kong/go-kong?
No, this PR replaces the other one I opened, I will close the old PR if/once this is approved
Does decK
or these tools ever use PATCH
or POST
?
Does
decK
or these tools ever usePATCH
orPOST
?
not that I'm aware of, but that's a good question for @Kong/team-apiops maybe
failing CI because httpbin.org is down ... I'll try to rerun / merge later
Summary
the previous logic was filling defaults in the configuration that was passed to Kong. This was problematic, especially where
nils
were populated as defaults, e.g. if ashorthand_field
was passed with some value and the corresponding new field was auto-populated asnil
by decK , the auto-populated nil value would take precedence in Kong thus causing the shorthand_field to be ignored (see linked issues).This change applies the default values only to configurations used for
diff
, the original configuration from the file is passed to Kong as is.Configuration
Before the change
After the change
Issues resolved
KAG-5157 KAG-5210
Documentation
Testing