search

Kong / go-database-reconciler

Apache License 2.0
5 stars 3 forks source link

fix: plugin shown as global despite a consumer-group present #134

Closed Prashansa-K closed 1 month ago

Prashansa-K commented 1 month ago

Prior to this fix, deck was reporting the plugins as global even if a consumer-group was attached to them. This was only a output problem, not a association problem. The fix checks if a consumer-group exists or not before reporting any plugin as global.

Fixes: https://github.com/Kong/deck/issues/1005

Documentation

Testing

codecov-commenter commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 42.76%. Comparing base (6d1bb06) to head (8c392b6).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #134 +/- ## ========================================== + Coverage 42.72% 42.76% +0.04% ========================================== Files 75 75 Lines 8820 8820 ========================================== + Hits 3768 3772 +4 + Misses 4588 4586 -2 + Partials 464 462 -2 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.