search

Kong / go-database-reconciler

Apache License 2.0
5 stars 3 forks source link

fix: added fix to allow one consumer to be in >1 consumer-groups. #140

Closed Prashansa-K closed 1 month ago

Prashansa-K commented 1 month ago

gdr version 1.39.2 introduced a bug where a consumer was limited to only one consumer-group. Adding the consumer in >1 group was resulting in an error on deck. This PR adds the fix for the same and an integration test.

See: https://github.com/Kong/deck/issues/1384

codecov-commenter commented 1 month ago

Codecov Report

Attention: Patch coverage is 0% with 9 lines in your changes missing coverage. Please review.

Project coverage is 29.95%. Comparing base (7c622bd) to head (999a82b).

Files with missing lines Patch % Lines
pkg/state/consumer_group_consumers.go 0.00% 8 Missing :warning:
tests/integration/test_utils.go 0.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #140 +/- ## ========================================== - Coverage 29.96% 29.95% -0.02% ========================================== Files 106 106 Lines 12583 12589 +6 ========================================== Hits 3771 3771 - Misses 8352 8358 +6 Partials 460 460 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.