Closed Prashansa-K closed 3 months ago
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.
Attention: Patch coverage is 77.55102%
with 11 lines
in your changes missing coverage. Please review.
Project coverage is 59.79%. Comparing base (
a9ec2d5
) to head (3a072ec
).
Files | Patch % | Lines |
---|---|---|
kong/utils.go | 77.55% | 6 Missing and 5 partials :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Added a unit test for the recent changes @GGabriele.
As of now, deprecated fields are renamed to shorthand_fields in all schemas, as per the conventions. Till now, we do not fill any values for these fields while attempting to fill config records for plugins. This creates a visualisation problem in decK. Everytime, a deck diff or deck sync command is issued, it shows that the deprecated field values are changed and need to be updated, thus running an unnecessary update process each time and also confusing end users.
Check https://github.com/Kong/deck/issues/1251 for details.
This fix attempts to fill defaults for the shorthand_fields, retaining their values, if passed. Also, since shorthand_fields take priority over normal/nested fields in the gateway, if any changes are detected in shorthand_fields, it is backfilled to nested fields as well.