search

Kong / go-pdk

Write Kong plugins in Go! 🦍
https://pkg.go.dev/github.com/Kong/go-pdk
Apache License 2.0
144 stars 48 forks source link

fix: add ctx test handlers, fix hanging channel, fix typo #174

Closed winslowdibona closed 4 months ago

winslowdibona commented 5 months ago

This PR attempts to address several issues:

  1. Adds support for kong.ctx.shared.get and kong.ctx.shared.set in the test module
  2. Fixes a typo finnished -> finished
  3. Includes changes introduced by @jakeslee in PR 170 to fix issue with hanging channel in kong.response.exit
CLAassistant commented 5 months ago

CLA assistant check
All committers have signed the CLA.

winslowdibona commented 5 months ago

@jakeslee I've included your changes I saw on PR 170 in mine as I was facing the same issue when testing locally.

winslowdibona commented 5 months ago

@fffonion @gszr Who should contributors reach out to when seeking reviews/approval on pull requests? I ask you all because I see your comments/commits on recent PRs

gszr commented 4 months ago

@winslowdibona - Thank you for the PR!