search

Kong / httpbin

ISC License
12 stars 4 forks source link

chore(ci): remove precommit workflow #36

Closed pmalek closed 9 months ago

pmalek commented 9 months ago

Summary

https://github.com/pre-commit/action is in maintenance mode and has been failing for a while now.

This PR removes it.

czeslavo commented 9 months ago

If we're removing the workflow, shouldn't we delete its config as well? https://github.com/Kong/httpbin/blob/main/.pre-commit-config.yaml

As I can see in general it was meant to run some linting - do we have something in its place?

czeslavo commented 9 months ago

BTW won't this workflow be synced again anyway? The comment says:

File is synced from Kong/template-generic and will be overwritten

Edit: ok, it shouldn't as this repo is not mentioned in the Kong/template-generic config.

pmalek commented 9 months ago

It won't because it's not in https://github.com/Kong/template-generic/blob/main/.github/template-sync.yml

But I believe I can fix it. Let me try #37