search

Kong / insomnia

The open-source, cross-platform API client for GraphQL, REST, WebSockets, SSE and gRPC. With Cloud, Local and Git storage.
https://insomnia.rest
Apache License 2.0
34.85k stars 1.97k forks source link

Keybindings don't respect keymap #5567

Open rickdgeerling opened 1 year ago

rickdgeerling commented 1 year ago

Expected Behavior

I press Ctrl+E and the environment editor opens.

Actual Behavior

A modal to duplicate a request opens instead.

Reproduction Steps

  1. On a Linux machine with a Querty keyboard
  2. Set an alternative keyboard layout (Dvorak)
  3. In the main window, press Ctrl+E to open the environment editor (On Drovak, the E is mapped onto the D-key)
  4. Duplicate request modal opens

Is there an existing issue for this?

Additional Information

It's on a Linux machine, with a Querty keyboard but a Dvorak layout (setxkbmap dvorak).

Shortcuts defined in the window-menus do work as expected (e.g.: toggle devtools, hide, quit).

A quick look at the changelog points to #4937 as the cause.

Version: Insomnia 2022.7.0
Build date: 12/15/2022
OS: Linux x64 5.15.81-1-MANJARO
Electron: 22.0.0
Node: 16.17.1
V8: 10.8.168.20-electron.0
Architecture: x64

Insomnia Version

2022.7.0

What operating system are you using?

Other Linux

Operating System Version

Linux x64 5.15.81-1-MANJARO

Installation method

pamac

Last Known Working Insomnia version

2022.6.0

macbookandrew commented 1 year ago

I can confirm this is happening on macOS as well with the Dvorak keyboard layout.

To reproduce:

  1. Open System Settings > Keyboard
  2. Add a new input source
  3. Choose Dvorak
  4. Try any keyboard shortcut in Insomnia
    • Example: the physical r key maps to p on the Dvorak layout; pressing the physical keys command+r should open the quick switcher (defined as command+p) but instead sends the request
macbookandrew commented 1 year ago

@gatzjames as the author of #4937, do you have any ideas?