Kong / insomnia

The open-source, cross-platform API client for GraphQL, REST, WebSockets, SSE and gRPC. With Cloud, Local and Git storage.
https://insomnia.rest
Apache License 2.0
34.74k stars 1.97k forks source link

Unexpected partial matches when filtering for requests #6494

Open brendanm-stripe opened 1 year ago

brendanm-stripe commented 1 year ago

Expected Behavior

When entering multiple words in the sidebar request filter, I expect the filtered result set to only include requests which match all words in filter. This was the existing behaviour recently and make it easy to filter large lists of requests by describing details in the name.

Actual Behavior

When multiple words are entered in the filter, requests are returned if they match any of the words in the filter.

This makes it difficult to filter large request lists by attributes described in the request name/label as was previously possible.

Reproduction Steps

1/ Create three requests with names: fizz buzz fizz buzz

2/ Enter filter term: fizz buzz

3/ Look at filtered results.

Expect only request "fizz buzz" (matches both words in filter) but get all three instead.

Is there an existing issue for this?

Additional Information

I suspect this may be related to the use of fuzzyMatchAll in https://github.com/Kong/insomnia/pull/6323

Insomnia-filtering

Insomnia Version

2023.5.8

What operating system are you using?

macOS

Operating System Version

macOS Ventura 13.5.2

Installation method

download from insomnia.rest, auto updated

Last Known Working Insomnia version

unknown but believe < 2023.5.0

filfreire commented 1 year ago

@brendanm-stripe thanks for reporting this, we can also reproduce

image

brendanm-stripe commented 1 year ago

I have since discovered, accidentally, that I can kind of work around this by omitting spaces in my filter terms. The catch here is that the terms need to be in the correct order matching the request name:

fizz-buzz-all fizz-buzz-2

This is also a bit off because I would not actually expect either request to match in the above without a space, but allows me to mostly keep going.

jayant-vashisth commented 9 months ago

is this open or anyone working on this?

harshitrajsinha commented 2 months ago

Cannot reproduce the issue, looks like it is fixed now. Hence can be closed

issue_rep

issue_rep_res