search

Kong / kong-build-tools

Build tools to package and release Kong
Apache License 2.0
83 stars 72 forks source link

fix(kong-ngx-build): set default value for KONG_OPENSSL_VER #623

Closed flrgh closed 1 year ago

flrgh commented 1 year ago

I've been seeing build failures against Kong/kong:master:

https://github.com/Kong/kong/actions/runs/3624858627/jobs/6112277211

Seems as though KONG_OPENSSL_VER has no value set, so checking it against 0 to see if it's "disabled" (if [ $KONG_OPENSSL_VER != 0 ]; then [...]) always tricks the script into thinking it's enabled. We don't check for undefined vars in this script so this is making it all the way to where we build the url for curl (https://github.com/Kong/kong-openssl/releases/download/$KONG_OPENSSL_VER/$package_architecture-$OSTYPE.tar.gz):

You've failed me for the last time! (curl --fail -sSLo openssl.tar.gz https://github.com/Kong/kong-openssl/releases/download//x86_64-linux-gnu.tar.gz)

github-actions[bot] commented 1 year ago

:tada: This PR is included in version 4.41.1 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: