search

Kong / kong-operator

Kong Operator for Kubernetes and OpenShift
https://konghq.com
Apache License 2.0
58 stars 27 forks source link

Update Chart.yaml #58

Closed jose-j01 closed 3 years ago

jose-j01 commented 3 years ago

appVersion should be of type string but it's of type float64

CLAassistant commented 3 years ago

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

rainest commented 3 years ago

How did you encounter this in practice/what failed?

This change should go upstream to https://github.com/Kong/charts, since we don't want the plain chart and chart in the operator to diverge.

While YAML's helpful type coercions are a common problem, I'm curious how we didn't get a report for a similar issue on the chart repo earlier--it's had an appVersion that can convert to float for quite some time. I haven't encountered complaints from Helm (embedded within the operator or otherwise) about it, but it's possible there's logic in Helm that normally ignores such issues, but not with some specific workflows.

stale[bot] commented 3 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

rainest commented 3 years ago

https://github.com/Kong/charts/pull/343 handled this upstream. Next chart release, which we'll also want to roll an operator release for, is pending a migration of our Enterprise Kong images off Bintray.