search

Kong / kong-plugin-openwhisk

A kong plugin to invoke OpenWhisk action (serverless functions as service).
Apache License 2.0
9 stars 12 forks source link

feat(ee) encrypt key if keychain present #20

Closed kikito closed 1 year ago

kikito commented 2 years ago

This PR encrypts the key field if the keychain feature (an EE-exclusive feature at the moment) is present.

Tieske commented 1 year ago

@wheelerlaw I rebased this PR after merging the CI changes, yet it fails again with the same errors. Any ideas?

Tieske commented 1 year ago

merged this fix; https://github.com/Kong/kong-license/pull/19 so now the CI fails properly on the license failure. But still, that should not happen, seems something is still wrong with the secret.

I reran another repo, using the same license action, that one succeeded properly.

wheelerlaw commented 1 year ago

Forks of public repositories do not have access to secrets, according to GH's documentation:

Anyone can fork a public repository, and then submit a pull request that proposes changes to the repository's GitHub Actions workflows. Although workflows from forks do not have access to sensitive data such as secrets, they can be an annoyance for maintainers if they are modified for abusive purposes.

So this PR will need to be reopened from the branch inside this repository. I tested this here.