Closed fffonion closed 3 years ago
This is Enterprise-specific code. I'm not sure why this is included here in an Open-source repository. I'd advise against including this here. And if we do decide to do this, please make sure you include the why in your commit message.
Good call; didn't even notice that. This should be moved into Enterprise code base instead.
@hbagdi @mikefero although this PR invokes enterprise code but there's no new enterprise feature being implemented here. if we want to move this to EE codebase, it will become either a EE fork, which won't work with the status_api model, or a dynamically loaded lua module that introduces headaches.
i agree we can add dataplanes
. as admin_seats
, product_subscription
, and support_plan
basically descibes the license but not controls the funcionality of kong (correct me if i'm wrong), i don't think it make much sense to monitor them.
@hbagdi @mikefero although this PR invokes enterprise code but there's no new enterprise feature being implemented here. if we want to move this to EE codebase, it will become either a EE fork, which won't work with the status_api model, or a dynamically loaded lua module that introduces headaches.
I understand the pain here but that's really the right thing to do. You could add hooks tot he OSS code-base to ease with the pain.
IMO this is not necessarily the 'wrong' approach, as there is no sensitive code being added -- the code here simply calls an enterprise-specific API. Moving it over to the enterprise side might add unnecessary maintenance burden.