fix(exporter) attach subsystem label to memory stats

Kong / kong-plugin-prometheus

Prometheus plugin for Kong - this plugin has been moved into https://github.com/Kong/kong, please open issues and PRs in that repo

Apache License 2.0

119 stars 57 forks source link

Closed fffonion closed 3 years ago

fffonion commented 3 years ago

Memory stats in HTTP and Stream subsystem are independent, attaching the label so prometheus won't complain about duplicate metrics

hbagdi commented 3 years ago

Please resolve the conflict and rebase. subsystem is not a good name for a label because it might conflict with existing setups. kong-subsystem?

fffonion commented 3 years ago

@hbagdi Could you take another review?

fffonion commented 3 years ago

Need to fix the test.

fffonion commented 3 years ago

The tests are failing but seems not related 🤔 @hbagdi I addressed your comments and if there's no objection from you I'll merge this PR.

hbagdi commented 3 years ago

I was about to approve but had one last comment.