Do not expect uninitialized counters in output - Githubissues

Kong / kong-plugin-prometheus

Prometheus plugin for Kong - this plugin has been moved into https://github.com/Kong/kong, please open issues and PRs in that repo

Apache License 2.0

119 stars 57 forks source link

Do not expect uninitialized counters in output #142

Closed Tieske closed 3 years ago

Tieske commented 3 years ago

The problem was with kong_enterprise_license_errors.

kong_enterprise_license_errors was not initialized, but was tested to be 0, this caused the CI failure.
kong_nginx_metric_errors_total was initialized, and tested to be 0

For consistency the following changes were made:

kong_nginx_metric_errors_total no longer initialized
both of them tested to be absent instead of 0

Tieske commented 3 years ago

@fffonion @hbagdi please check this one carefully, I'm not enough into Prometheus to know whether not-initializing actually poses an issue (some others were not, so I assumed it to be ok).

Tieske commented 3 years ago

this builds on top of the other PR, which has non-controversial fixes.

Tieske commented 3 years ago

The only consistent failure remaining is the one against Kong master branch. The fix for that one is in https://github.com/Kong/kong/pull/7529

fffonion commented 3 years ago

I think technically having consistency is good, but since prometheus.lua is a vendored 3rd library, I don't feel it's a good idea to diverage its behaviour here from the upstream. @Tieske How about we initialize kong_enterprise_license_errors instead, Will that solve the problem here?

Tieske commented 3 years ago

How about we initialize kong_enterprise_license_errors instead, Will that solve the problem here?

that was the alternative, didn't know the lib was "vendored".

Tieske commented 3 years ago

replaced by #144