search

Kong / kong-plugin-prometheus

Prometheus plugin for Kong - this plugin has been moved into https://github.com/Kong/kong, please open issues and PRs in that repo
Apache License 2.0
119 stars 57 forks source link

feat(prometheus) sync upstream changes for vendored prometheus library #146

Closed fffonion closed 3 years ago

fffonion commented 3 years ago

Changelog from upstream

ab14b2f3fd23d85cf032aab6b407aadc6b45cf1b Do not trim trailing .0 from bucket label values
9a03008849e09cd86fed86ac0771f959b6874347 feat: remove leading and trailing zeros in bucket label values (#119)
18124f16445369106386fb0d47c1e96c53fc0ed5 feat: histogram support reset (#114)
baeae794c5b21099e2b2c4750ba794bb41a5e26d Tidy up utf8-related comments and tests
1b6137c6df094c3f755dc91ec9ba3be24b4c40ca Allow utf8 label values (#110)
97ba6cd0fc31b7f6c9d3f2bdc5514a966cbdd23d reset() should not log an error if metric value is not found (#106)
e2cb2af8ed6cc61a339c473f498d32f7fd47a96d Simplify library initialization (#94)
d45dddbb227d3decf8029332428ee4fcf5b0aefc Configurable name for the error metric (#91)
27bae6aae0cbdd9bf30de5d189dee76672659ee4 fix duplicate metric check (#89)

Backports are done in https://github.com/Kong/lua-resty-prometheus where one change that is removed due to debatable tradeoff between complexity and performance. To view what's different from upstream, please use this link https://github.com/Kong/lua-resty-prometheus/compare/upstream/master...Kong:test.

fffonion commented 3 years ago

Seeing some flakyness in CI around balancer metrics, probably caused by a bahaiviour change. i think it's not related by this PR. Will merge as is and figure out the flaky one shortly