feat(*) w3c trace context with expanded tracing header control

Kong / kong-plugin-zipkin

A Kong plugin for propogating zipkin spans and reporting spans to a zipkin server - this plugin has been moved into https://github.com/Kong/kong, please open issues and PRs in that repo

Apache License 2.0

60 stars 31 forks source link

feat(*) w3c trace context with expanded tracing header control #75

Closed kikito closed 4 years ago

kikito commented 4 years ago

This is an expansion over #69 . In addition of recognizing the W3C header tracing header, this PR adds a new option called header_type, with 4 possible values:

preserve: the plugin produces whatever format it receives on each request
b3-single: always use b3 single
b3: always use the "regular zipkin" headers, such as x-b3-traceid
w3c: use the w3c format

When options.header_type is set to anything other than preserve, and the trace headers don't match (for example the config is b3-single but we receive a w3c-trace-context) then we should send both kinds of headers. A warning is logged.

dalv666 commented 4 years ago

@kikito , do I understand correctly that this change will not support the header "uber-trace-id"? Is it possible to put in the configuration the name of the header, which will be responsible for the name of the trace header.

kikito commented 4 years ago

do I understand correctly that this change will not support the header "uber-trace-id"

Your understanding is correct: this change does not include that header.

Is it possible to put in the configuration the name of the header, which will be responsible for the name of the trace header.

That is not possible with this change.

hbagdi commented 4 years ago

@victorNewRelic Please fill in the contributor form to claim your Kong swag: https://github.com/Kong/kong/blob/master/CONTRIBUTING.md#contributor-t-shirt

subvocal commented 4 years ago

Thanks, @hbagdi! Done!