search

Kong / kong-python-pdk

Write Kong plugins in Python (Experimental)
Apache License 2.0
40 stars 14 forks source link

Removing upper() to allow matching of attributes #69

Closed krahb closed 2 years ago

krahb commented 2 years ago

This PR fixes #66 . The names of the version and priority attributes of the module are defined in lowercase. Comparing these with the uppercase values of 'versions' and 'priority' will never match, so both version and priority attributes are never set according to the values passed in the start_dedicated_server function and remain at their defaults (being None and 0).

CLAassistant commented 2 years ago

CLA assistant check
All committers have signed the CLA.

fffonion commented 2 years ago

Thank you @krahb !

krahb commented 2 years ago

Hi,

Thanks for merging. I'm rather new to this process of contribution and I would like to know when the changes are actually present in the pypi package?

regards, Bob

On Sun, Jun 12, 2022, 16:44 Wangchong Zhou @.***> wrote:

Thank you @krahb https://github.com/krahb !

— Reply to this email directly, view it on GitHub https://github.com/Kong/kong-python-pdk/pull/69#issuecomment-1153192948, or unsubscribe https://github.com/notifications/unsubscribe-auth/AD45EW5ADP4YV7PCP6UQHULVOXZWJANCNFSM5YNKIO3Q . You are receiving this because you were mentioned.Message ID: @.***>

fffonion commented 2 years ago

@krahb I will release a 0.3.1 version soon #70 😄

krahb commented 2 years ago

thanks!

On Mon, Jun 13, 2022, 09:26 Wangchong Zhou @.***> wrote:

@krahb https://github.com/krahb I will release a 0.3.1 version soon #70 https://github.com/Kong/kong-python-pdk/pull/70 😄

— Reply to this email directly, view it on GitHub https://github.com/Kong/kong-python-pdk/pull/69#issuecomment-1153569665, or unsubscribe https://github.com/notifications/unsubscribe-auth/AD45EW7PBSMSSRIRPNL2WLTVO3PDLANCNFSM5YNKIO3Q . You are receiving this because you were mentioned.Message ID: @.***>