search

Kong / kong

🦍 The Cloud-Native API Gateway and AI Gateway.
https://konghq.com/install/#kong-community
Apache License 2.0
38.77k stars 4.77k forks source link

misdocumented breaking change in v3 #13203

Closed zwing99 closed 1 month ago

zwing99 commented 2 months ago

Is there an existing issue for this?

Kong version ($ kong version)

3.0

Current Behavior

in 2.X if you defined target_path on the service it was ignored by the aws-lambda plugin and never prepended to the path set sent in the json payload to lambda

Expected Behavior

In 3.X if you define target_path on the service it is prepend and this is apparently expected. HOWEVER, this is a breaking change to those expecting the target_path to be ignored. Can the changelog be update to reflect that #9058 and #9129 are in fact breaking changes to the 3.0 release.

Steps To Reproduce

  1. Set target_path on service
  2. Use aws-lambda plugin in 2.x vs 3.x

Anything else?

Please update the docs.

chronolaw commented 2 months ago

@oowl , I think that you are those PR's author, could you take a look at this issue? thanks.

zwing99 commented 2 months ago

@oowl and @chronolaw any updates here? Others? My organization had to roll back our upgrade from 2 -> 3 because of this breaking change. We need to make changes to the config before we can upgrade. It is our fault for configuring kong incorrectly and depending on bad behavior. However, patching this bug is a breaking change and I am just hoping to help others to hopefully catch it when reviewing the changelog.

StarlightIbuki commented 2 months ago

IMO, fixing a buggy behavior is not a breaking change. It's arguable whether we should consider fixing a bug used as a feature in a special case. @oowl votes for you and you need another vote to change the changelog.

oowl commented 1 month ago

IMO, fixing a buggy behavior is not a breaking change. It's arguable whether we should consider fixing a bug used as a feature in a special case. @oowl votes for you and you need another vote to change the changelog.

Agree, fixing a buggy behavior is not a breaking change. we do not add any break change log for bug fixes.

github-actions[bot] commented 1 month ago

This issue is marked as stale because it has been open for 14 days with no activity.

github-actions[bot] commented 1 month ago

Dear contributor,

We are automatically closing this issue because it has not seen any activity for three weeks. We're sorry that your issue could not be resolved. If any new information comes up that could help resolving it, please feel free to reopen it.

Your contribution is greatly appreciated!

Please have a look our pledge to the community for more information.

Sincerely, Your Kong Gateway team