xianghai2
commented
1 month ago Hi @TGeb-EV ,
Could you provide more details about your custom plugin? thank you.
And I could not reproduce this, it looks like that Kong 3.7.1 code base works smoothly for my custom plugin. I did following things:
============================ My custom plugin:
haix@kong:~/workspace/371$ git status On branch release/3.7.1 Your branch is up to date with 'origin/release/3.7.1'.
Changes not staged for commit:
(use "git add
Untracked files:
(use "git add
no changes added to commit (use "git add" and/or "git commit -a")
diff --git a/kong.conf.default b/kong.conf.default index fac253492..2aa817864 100644 --- a/kong.conf.default +++ b/kong.conf.default @@ -138,7 +138,7 @@ #
Example: 0.25, this should account for 25% of all traces.
- +plugins = bundled,my-plugin
plugins = bundled # Comma-separated list of plugins this node
# should load. By default, only plugins
# bundled in official distributions arehaix@kong:~/workspace/371$ ls -l kong/plugins/my-plugin/ total 8 -rw-rw-r-- 1 haix haix 578 Jul 29 17:17 handler.lua -rw-rw-r-- 1 haix haix 209 Jul 29 17:17 schema.lua
haix@kong:~/workspace/371$ cat kong/plugins/my-plugin/handler.lua local MyPluginHandler = { PRIORITY = 1000, VERSION = "0.0.1", }
function MyPluginHandler:response(config) -- Implement logic for the access phase here (http) kong.response.set_header("X-MyPlugin", "response") end
function MyPluginHandler:access(config) -- Implement logic for the access phase here (http) kong.log("MyPlugin: access") end
-- function MyPluginHandler:header_filter(config) -- Implement logic for the header_filter phase here (http) -- kong.log("MyPlugin header_filter: " .. kong.response.get_header("Server")) -- end
return MyPluginHandler
haix@kong:~/workspace/371$ cat kong/plugins/my-plugin/schema.lua local PLUGIN_NAME = "my-plugin"
local schema = { name = PLUGIN_NAME, fields = { { config = { type = "record", fields = { }, }, }, }, }
return schema
================================== Start upstream web server listening on port 8888
build nginx from source and install: auto/configure --with-http_dav_module --prefix="/home/haix/oss/ngx/build/test" make make install cd build/test ./sbin/nginx -c ./conf/nginx.conf
check and verify ETag:
haix@kong:~$ curl -i localhost:8888 HTTP/1.1 200 OK Server: nginx/1.27.0 Date: Mon, 29 Jul 2024 08:47:54 GMT Content-Type: text/html Content-Length: 615 Last-Modified: Mon, 29 Jul 2024 08:44:30 GMT Connection: keep-alive ETag: "66a7566e-267" Accept-Ranges: bytes
<!DOCTYPE html>
<html>
<head>
<title>Welcome to nginx!</title>
<style>
html { color-scheme: light dark; }
body { width: 35em; margin: 0 auto;
font-family: Tahoma, Verdana, Arial, sans-serif; }
</style>
</head>
<body>
<h1>Welcome to nginx!</h1>
<p>If you see this page, the nginx web server is successfully installed and
working. Further configuration is required.</p>
<p>For online documentation and support please refer to
<a href="http://nginx.org/">nginx.org</a>.<br/>
Commercial support is available at
<a href="http://nginx.com/">nginx.com</a>.</p>
<p><em>Thank you for using nginx.</em></p>
</body>
</html>haix@kong:~$
haix@kong:~$ curl --header 'If-Match: "66a7566e-267"' -i localhost:8888 HTTP/1.1 200 OK Server: nginx/1.27.0 Date: Mon, 29 Jul 2024 08:51:54 GMT Content-Type: text/html Content-Length: 615 Last-Modified: Mon, 29 Jul 2024 08:44:30 GMT Connection: keep-alive ETag: "66a7566e-267" Accept-Ranges: bytes
<!DOCTYPE html>
<html>
<head>
<title>Welcome to nginx!</title>
<style>
html { color-scheme: light dark; }
body { width: 35em; margin: 0 auto;
font-family: Tahoma, Verdana, Arial, sans-serif; }
</style>
</head>
<body>
<h1>Welcome to nginx!</h1>
<p>If you see this page, the nginx web server is successfully installed and
working. Further configuration is required.</p>
<p>For online documentation and support please refer to
<a href="http://nginx.org/">nginx.org</a>.<br/>
Commercial support is available at
<a href="http://nginx.com/">nginx.com</a>.</p>
<p><em>Thank you for using nginx.</em></p>
</body>
</html>haix@kong:~$ curl --header 'If-None-Match: "66a7566e-267"' -i localhost:8888 HTTP/1.1 304 Not Modified Server: nginx/1.27.0 Date: Mon, 29 Jul 2024 08:52:13 GMT Last-Modified: Mon, 29 Jul 2024 08:44:30 GMT Connection: keep-alive ETag: "66a7566e-267"
haix@kong:~$
=============================== start kong with my custom plugin:
(kong-dev) haix@kong:~/workspace/371$ kong version 3.7.1
kong start -c ./kong.conf.default
curl -s localhost:8001 | jq '.plugins.available_on_server."my-plugin"'
curl -i -s -X POST http://localhost:8001/services \ --data name=example_service \ --data url='http://localhost:8888'
curl -is -X POST http://localhost:8001/services/example_service/plugins \ --data 'name=my-plugin'
curl -i -X POST http://localhost:8001/services/example_service/routes \ --data 'paths[]=/mock' \ --data name=example_route
================================= Verify "If-Match" header request with Kong
(kong-dev) haix@kong:~/workspace/371$ curl --header 'If-Match: "66a7566e-267"' -i http://localhost:8000/mock HTTP/1.1 200 OK Content-Type: text/html; charset=UTF-8 Connection: keep-alive Server: nginx/1.27.0 Date: Mon, 29 Jul 2024 09:38:04 GMT Last-Modified: Mon, 29 Jul 2024 08:44:30 GMT ETag: "66a7566e-267" Accept-Ranges: bytes Content-Length: 615 X-MyPlugin: response X-Kong-Upstream-Latency: 0 X-Kong-Proxy-Latency: 1 Via: kong/3.7.1 X-Kong-Request-Id: bc9e504b7785af61a9bf456b8c7cfd5e
<!DOCTYPE html>
<html>
<head>
<title>Welcome to nginx!</title>
<style>
html { color-scheme: light dark; }
body { width: 35em; margin: 0 auto;
font-family: Tahoma, Verdana, Arial, sans-serif; }
</style>
</head>
<body>
<h1>Welcome to nginx!</h1>
<p>If you see this page, the nginx web server is successfully installed and
working. Further configuration is required.</p>
<p>For online documentation and support please refer to
<a href="http://nginx.org/">nginx.org</a>.<br/>
Commercial support is available at
<a href="http://nginx.com/">nginx.com</a>.</p>
<p><em>Thank you for using nginx.</em></p>
</body>
</html>(kong-dev) haix@kong:~/workspace/371$ curl --header 'If-None-Match: "66a7566e-267"' -i http://localhost:8000/mock HTTP/1.1 304 Not Modified Connection: keep-alive Server: nginx/1.27.0 Date: Mon, 29 Jul 2024 09:38:14 GMT ETag: "66a7566e-267" Last-Modified: Mon, 29 Jul 2024 08:44:30 GMT X-MyPlugin: response X-Kong-Upstream-Latency: 1 X-Kong-Proxy-Latency: 2 Via: kong/3.7.1 X-Kong-Request-Id: 15b7476e7978010c2f210616bb1fc42c
(kong-dev) haix@kong:~/workspace/371$
TGeb-EV
chobits
Is there an existing issue for this?
Kong version (
$ kong version)3.7.1
Current Behavior
A custom plugin in response phase has sideeffect to if-match/etag handling. A global configured plugin (enabled or not) leads to 412 responses if Requests with "If-Match) header are incoming
Expected Behavior
The if-match header should be ignored, with and without the configured plugin. Without everything works as intended
Steps To Reproduce
`local TestPlugin = { PRIORITY = 850, VERSION = '0.0.1' }
function TestPlugin:response(conf)
end
return TestPlugin `
Anything else?
No response