Kong / kongponents

🦍 Kong Vue Component Library

https://kongponents.konghq.com

Apache License 2.0

122 stars 19 forks source link

feat(kpop): refactor using floating ui [KHCP-11957] #2204

Closed portikM closed 2 months ago

portikM commented 3 months ago

Summary

Replaces usage of popper.js with Floating UI

Breaking changes:

KPop
- placement prop options have changed
- hidePopover prop has been removed (use exposed by the component hidePopover method instead)
- target prop has been removed
- positionFixed prop has been removed
- k-popover class has been replaced with popover (instead, k-popover class has been given to outer-most element)
KDateTimePicker
- hidePopover property in DateTimePickerState interface has been renamed to popoverOpen
Other components
- positionFixed prop has been removed from KSelect, KMultiselect and KTooltip

PR Checklist

[ ] Conventional Commits all commits follow the conventional commit standards outlined in the main README.
[ ] Tests coverage: test coverage was added for new features and bug fixes
[ ] Docs: includes a technically accurate README

netlify[bot] commented 3 months ago

Deploy Preview for kongponents-sandbox ready!

Name	Link
Latest commit	db1b459c79c685c4896a719cf033b49915a5cc4d
Latest deploy log	https://app.netlify.com/sites/kongponents-sandbox/deploys/666705bb790461000820db8b
Deploy Preview	https://deploy-preview-2204--kongponents-sandbox.netlify.app
Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] commented 3 months ago

Deploy Preview for kongponents ready!

Name	Link
Latest commit	db1b459c79c685c4896a719cf033b49915a5cc4d
Latest deploy log	https://app.netlify.com/sites/kongponents/deploys/666705bb99e0850008a85a63
Deploy Preview	https://deploy-preview-2204--kongponents.netlify.app
Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

portikM commented 3 months ago

I'm noticing a few style regressions in other elements.

Pagination

Extra padding, border, double border at the bottom, etc.

Popover

When I click on the "Non-fixed positioning" button, the popover "flashes" rapidly; something def wrong here.

Datetime Picker

Spacing between input and popover is larger than previous version

There is also additional padding in the popover that wasn't there before

KTable

The column visibility menu is no longer functional - when I click the icon nothing happens