Kong / kongponents

🦍 Kong Vue Component Library
https://kongponents.konghq.com
Apache License 2.0
121 stars 19 forks source link

fix(kfileupload, kselect, kmultiselect): kinput id [KHCP-12336] #2241

Closed portikM closed 1 month ago

portikM commented 1 month ago

Summary

Binding id to KInput in KFileUpload, KSelect and KMultiselect through v-bind-once directive creates a problem where the id gets assigned to the wrong element because the directive ignores the inherritAttrs: false setting. That means:

Solution: do not rely on v-bind-once in said components and

PR Checklist

netlify[bot] commented 1 month ago

Deploy Preview for kongponents-sandbox ready!

Name Link
Latest commit 222f04d3b0772788191b0f79000f1f186483903a
Latest deploy log https://app.netlify.com/sites/kongponents-sandbox/deploys/66725506bc972b000825ad0a
Deploy Preview https://deploy-preview-2241--kongponents-sandbox.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] commented 1 month ago

Deploy Preview for kongponents ready!

Name Link
Latest commit 222f04d3b0772788191b0f79000f1f186483903a
Latest deploy log https://app.netlify.com/sites/kongponents/deploys/6672550640870b000888df63
Deploy Preview https://deploy-preview-2241--kongponents.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

kongponents-bot commented 1 month ago

:tada: This PR is included in version 9.0.0-alpha.179 :tada:

The release is available on:

Your semantic-release bot :package::rocket: