search

Kong / kubernetes-ingress-controller

:gorilla: Kong for Kubernetes: The official Ingress Controller for Kubernetes.
https://docs.konghq.com/kubernetes-ingress-controller/
Apache License 2.0
2.2k stars 590 forks source link

Deprecate the sidecar (non-GD) mode in DB-less #4671

Open mflendrich opened 1 year ago

mflendrich commented 1 year ago

Is there an existing issue for this?

Problem Statement

702 has added Gateway Discovery that has been offered as a (default on) alternative in the deploy manifests and in the kong/ingress Helm chart.

3.0 is good time to officially discontinue the legacy (sidecar) model.

Proposed Solution

Additional information

This only refers to DB-less.

Acceptance Criteria

mflendrich commented 1 year ago

~Blocked by https://github.com/Kong/kubernetes-ingress-controller/issues/4698~

mflendrich commented 11 months ago

~Tracking DB mode GD in https://github.com/Kong/kubernetes-ingress-controller/issues/4751~

rainest commented 10 months ago

Explicitly disallow the sidecar model in the Kong/kong Helm chart if KIC >= 3.0.

This isn't really possible as such. The sidecar model is the only way kong can deploy both the controller and proxy with a single release. ingress is automating some of the work to create multiple releases.

We can't really set up kong to support both sidecar and separate Deployments without making the settings and templates both harder to understand, so I would strongly recommend against it. Supporting only one mode of operation simplifies usage and development, so unless we have a strong reason to support sidecar mode still, we should instead make kong only support multiple Deployments, and then work on figuring out a migration plan for releases created with ingress so that we're no longer stuck with the limitations inherent to umbrella charts.

There shouldn't be any reason to need to use the sidecar model AFAIK, and keeping it if so wouldn't buy us anything other than consistency with earlier versions for consistency's sake.

pmalek commented 10 months ago

Make kong/ingress the only recommended way of installing KIC in the documentation.

README.md already points users to use the ingress chart.

mflendrich commented 10 months ago

Blocked by https://github.com/Kong/charts/issues/921