Closed pmalek closed 1 month ago
@pmalek Please check if there are nothing in the current webhook that can be moved to CRD annotations. If there is anything to do, please move it to milestone 3.4, otherwise close it.
Just did a spot check and I don't see anything obvious that could be moved to CEL/code markers.
Most of what we do in KIC's admission webhook these days is either cross object validation or validating against Gateway schema, neither of which can be done in CEL/code markers.
Closing.
Problem statement
5103 tries to solve #5061 but leaves the CRD validations unreviewed.
For instance:
KongConsumer
'sUsername
is required (enforced in admission webhook) but that could easily be changed to a required field on the CRD level via:This unfortunately can only be done when the
// +kubebuilder:validation:Optional
is removed from the package as that overrides the field level setting.Acceptance criteria
main