Kong / kubernetes-ingress-controller

:gorilla: Kong for Kubernetes: The official Ingress Controller for Kubernetes.
https://docs.konghq.com/kubernetes-ingress-controller/
Apache License 2.0
2.2k stars 590 forks source link

Revise CRD code markers/validations #5105

Closed pmalek closed 1 month ago

pmalek commented 10 months ago

Problem statement

5103 tries to solve #5061 but leaves the CRD validations unreviewed.

For instance:

Acceptance criteria

randmonkey commented 1 month ago

@pmalek Please check if there are nothing in the current webhook that can be moved to CRD annotations. If there is anything to do, please move it to milestone 3.4, otherwise close it.

pmalek commented 1 month ago

Just did a spot check and I don't see anything obvious that could be moved to CEL/code markers.

Most of what we do in KIC's admission webhook these days is either cross object validation or validating against Gateway schema, neither of which can be done in CEL/code markers.

Closing.