Open pmalek opened 1 month ago
That is something that existed before introducing FallbackConfiguration
. I'm not sure what the desired behavior should be here, but IMO emitting KongConfigurationTranslationFailed
should be good enough in any case (fallback enabled or not) as that's similar to other translation errors (e.g. ignoring CACerts with invalid secret content).
when using fallback configuration without backfilling, the object annotated with the non-existing plugin gets removed from the applied configuration
If we'd like to make this happen, that would require another refactor that would integrate translation failures with the fallback somehow. Definitely not something easy to implement.
Is there an existing issue for this?
Current Behavior
When users use a custom plugin in
konghq.com/plugins
annotation e.g. like so:then KIC emits configuration without this plugin, emits
KongConfigurationSucceeded
event, and the following error log:Expected Behavior
Expected behavior yet to be decided but I'd expect that
KongConfigurationTranslationFailed
eventSteps To Reproduce
Kubernetes version
No response
Anything else?
Relevant piece of code that skips creation of failure events (through
failuresCollector
) : https://github.com/Kong/kubernetes-ingress-controller/blob/e7b3048dfa2b311009efb8dd3035cbec41f87b8a/internal/dataplane/kongstate/kongstate.go#L490-L495