Improve observability around config sync - Githubissues

Kong / kubernetes-ingress-controller

:gorilla: Kong for Kubernetes: The official Ingress Controller for Kubernetes.

https://docs.konghq.com/kubernetes-ingress-controller/

Apache License 2.0

2.16k stars 592 forks source link

Improve observability around config sync #6191

Open lahabana opened 3 weeks ago

lahabana commented 3 weeks ago

Is there an existing issue for this?

[X] I have searched the existing issues

Does this enhancement require public documentation?

[X] I have added an Acceptance Criteria item for adding and/or adjusting public documentation (if applicable)

Problem Statement

There are metrics to see how long sync takes: https://docs.konghq.com/kubernetes-ingress-controller/latest/production/observability/prometheus/#ingress_controller_configuration_push_duration_milliseconds

A user is suggesting adding this to logs.

https://github.com/Kong/kubernetes-ingress-controller/blob/95af584ab560822a40ee6a1dd66a2005f9663e71/internal/dataplane/sendconfig/sendconfig.go#L104

Is this something we want to do?

Proposed Solution

No response

Additional information

No response

Acceptance Criteria

[ ] Potentially log duration

mheap commented 3 weeks ago

The request is a little more involved. They'd like timings for each phase e.g.

Fetch from k8s API server
Translate to Kong format
Sync with Konnect

lahabana commented 1 week ago

This looks a lot like tracing to me but tracing without an originator is a little unusual.

lahabana commented 1 week ago

Let's go for logs as a first step we can always improve later