Closed czeslavo closed 5 days ago
Attention: Patch coverage is 0%
with 14 lines
in your changes missing coverage. Please review.
Project coverage is 39.1%. Comparing base (
3fa3bc7
) to head (15f7a40
).:exclamation: Current head 15f7a40 differs from pull request most recent head 16ce72a
Please upload reports for the commit 16ce72a to get more accurate results.
Files | Patch % | Lines |
---|---|---|
internal/dataplane/kong_client.go | 0.0% | 14 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
What this PR does / why we need it:
We should try recovering with the fallback configuration (either generated or the persisted last valid one) only if we get an expected
UpdateError
from theUpdateStrategy
. Otherwise, we can assume the error is unrecoverable through the fallback configuration (e.g. transient network errors, gateways returning 5xx, etc.).It relies on https://github.com/Kong/go-kong/pull/452.
Which issue this PR fixes:
Fixes https://github.com/Kong/kubernetes-ingress-controller/issues/6218.
PR Readiness Checklist:
Complete these before marking the PR as
ready to review
:CHANGELOG.md
release notes have been updated to reflect any significant (and particularly user-facing) changes introduced by this PR