search

Kong / kubernetes-ingress-controller

:gorilla: Kong for Kubernetes: The official Ingress Controller for Kubernetes.
https://docs.konghq.com/kubernetes-ingress-controller/
Apache License 2.0
2.2k stars 590 forks source link

chore: temporarily disable konnect roles cleanup #6254

Closed czeslavo closed 3 months ago

czeslavo commented 3 months ago

What this PR does / why we need it:

Workaround to unblock CI. https://github.com/Kong/kubernetes-ingress-controller/issues/6253 tracks fixing this.

pmalek commented 3 months ago

https://github.com/Kong/kubernetes-ingress-controller/actions/workflows/cleanup.yaml seems to be passing now.

image

Anything changed? 🤔

czeslavo commented 3 months ago

@pmalek It started passing because I generated a new PAT for a service account (it's no longer possible to generate PATs for regular users). Code responsible for cleaning up roles was relying on /me endpoint that was working only with PATs for regular users. The cleanup workflow passes because there are no control planes and in effect, no roles to clean up as well, therefore we do not get to the point where /me endpoint is called. https://github.com/Kong/kubernetes-ingress-controller/issues/6253 is still required.

2024-06-27T07:03:51.6687806Z 2024-06-27T07:03:51.668Z   INFO    cleanup/konnect_runtime_groups.go:83    Control plane was not created by the tests, skipping    {"name": "default"}
2024-06-27T07:03:51.6689969Z 2024-06-27T07:03:51.668Z   INFO    cleanup/konnect_runtime_groups.go:103   No control planes to clean up
2024-06-27T07:03:51.6691892Z 2024-06-27T07:03:51.668Z   INFO    cleanup/konnect_runtime_groups.go:120   No control planes to clean up, skipping listing roles
2024-06-27T07:03:51.6693786Z 2024-06-27T07:03:51.668Z   INFO    cleanup/konnect_runtime_groups.go:146   No roles to delete