search

Kong / kubernetes-telemetry

Go library for telemetry in Kong's Kubernetes products
Apache License 2.0
5 stars 2 forks source link

Figure out which logging package to use and replace already used logrus with it #48

Open pmalek opened 2 years ago

pmalek commented 2 years ago

As of now, we're using logrus as logging package of choice.

As of now it's in maintenance mode.

This issue track an effort to come up with one particular logging package that we can use as a replacement for logrus and use that instead.

programmer04 commented 1 year ago

I can recommend zerolog I used it in a quite big app and liked it

pmalek commented 1 year ago

Apart from logrus being in maintenance mode this issue also tries to capture a higher level problem which is proliferation of different logging packages being used throughout KIC, KGO and other repos (including this one).

There's also a thread on slack and this long standing issue in KIC: https://github.com/Kong/kubernetes-ingress-controller/issues/1893. Ideally we'd pick one interface which would be used throughout all our projects

programmer04 commented 4 months ago

Other projects (KGO and KIC) use

github.com/go-logr/logr
github.com/go-logr/zapr

hence KTF should use them too.

Moreover, in case of errors, they should be rather returned explicitly to handle by caller than log it directly in this library.