Kong / kubernetes-testing-framework

Golang Integration Testing Framework For Kubernetes APIs and Controllers.
https://konghq.com
Apache License 2.0
40 stars 10 forks source link

feat: support arbitrary Kuma Helm values #958

Closed rainest closed 10 months ago

rainest commented 10 months ago

Add support for arbitrary chart settings to the Kuma plugin, inspired by the existing Kong plugin functionality.

I added this to test some additional Kuma settings in CI to try and find some fix for the KIC session stickiness issues we've seen with Kong 3.6. Didn't find any fix, but this is generic enough that we may as well add it anyway.

codecov-commenter commented 10 months ago

Codecov Report

Attention: 11 lines in your changes are missing coverage. Please review.

Comparison is base (7816472) 60.17% compared to head (8aded75) 48.66%.

Files Patch % Lines
pkg/clusters/addons/kuma/builder.go 0.00% 7 Missing :warning:
pkg/clusters/addons/kuma/addon.go 0.00% 4 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #958 +/- ## =========================================== - Coverage 60.17% 48.66% -11.51% =========================================== Files 50 50 Lines 4045 4054 +9 =========================================== - Hits 2434 1973 -461 - Misses 1304 1810 +506 + Partials 307 271 -36 ``` | [Flag](https://app.codecov.io/gh/Kong/kubernetes-testing-framework/pull/958/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Kong) | Coverage Δ | | |---|---|---| | [integration-test](https://app.codecov.io/gh/Kong/kubernetes-testing-framework/pull/958/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Kong) | `48.66% <0.00%> (-11.51%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Kong#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.