search

Kong / ngx_wasm_module

Nginx + WebAssembly
Apache License 2.0
80 stars 7 forks source link

tests(*) opt-in Valgrind test cases #447

Closed thibaultcha closed 9 months ago

thibaultcha commented 10 months ago

Reworking the way we execute Valgrind checks. ATM, mostly tests on run time for different Wasm runtimes and splitting Valgrind workloads.

The goal of this work will be to make Valgrind tests opt-in: a select set of tests from the whole suite will be enabled for Valgrind testing, therefore avoiding duplicated Valgrind tests (or multiple functional tests with not difference in memory handling), and avoid having to filter-out hundreds of tests only to leave a few enabled ones.

codecov[bot] commented 10 months ago

Codecov Report

Merging #447 (e9015ff) into main (ecd7896) will increase coverage by 0.00492%. Report is 1 commits behind head on main. The diff coverage is 98.36066%.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/Kong/ngx_wasm_module/pull/447/graphs/tree.svg?width=650&height=150&src=pr&token=T0PT2Q9IAN&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Kong)](https://app.codecov.io/gh/Kong/ngx_wasm_module/pull/447?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Kong) ```diff @@ Coverage Diff @@ ## main #447 +/- ## =================================================== + Coverage 90.18238% 90.18730% +0.00491% =================================================== Files 46 46 Lines 8444 8489 +45 =================================================== + Hits 7615 7656 +41 - Misses 829 833 +4 ``` | [Files](https://app.codecov.io/gh/Kong/ngx_wasm_module/pull/447?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Kong) | Coverage Δ | | |---|---|---| | [src/common/proxy\_wasm/ngx\_proxy\_wasm.c](https://app.codecov.io/gh/Kong/ngx_wasm_module/pull/447?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Kong#diff-c3JjL2NvbW1vbi9wcm94eV93YXNtL25neF9wcm94eV93YXNtLmM=) | `92.95213% <100.00000%> (+0.02822%)` | :arrow_up: | | [src/common/proxy\_wasm/ngx\_proxy\_wasm\_host.c](https://app.codecov.io/gh/Kong/ngx_wasm_module/pull/447?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Kong#diff-c3JjL2NvbW1vbi9wcm94eV93YXNtL25neF9wcm94eV93YXNtX2hvc3QuYw==) | `93.96552% <100.00000%> (+0.63218%)` | :arrow_up: | | [src/http/proxy\_wasm/ngx\_http\_proxy\_wasm\_dispatch.c](https://app.codecov.io/gh/Kong/ngx_wasm_module/pull/447?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Kong#diff-c3JjL2h0dHAvcHJveHlfd2FzbS9uZ3hfaHR0cF9wcm94eV93YXNtX2Rpc3BhdGNoLmM=) | `90.67797% <66.66667%> (-1.08339%)` | :arrow_down: | ... and [2 files with indirect coverage changes](https://app.codecov.io/gh/Kong/ngx_wasm_module/pull/447/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Kong)