search

Kong / ngx_wasm_module

Nginx + WebAssembly
Apache License 2.0
93 stars 8 forks source link

tests(*) switch Valgrind tests from opt-out to opt-in #451

Closed thibaultcha closed 11 months ago

thibaultcha commented 11 months ago

Remove --- skip_valgrind block and helper in favor of an opt-in mode for Valgrind test cases.

codecov[bot] commented 11 months ago

Codecov Report

Merging #451 (c1a0201) into main (175f0b8) will decrease coverage by 0.12338%. Report is 1 commits behind head on main. The diff coverage is n/a.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/Kong/ngx_wasm_module/pull/451/graphs/tree.svg?width=650&height=150&src=pr&token=T0PT2Q9IAN&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Kong)](https://app.codecov.io/gh/Kong/ngx_wasm_module/pull/451?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Kong) ```diff @@ Coverage Diff @@ ## main #451 +/- ## =================================================== - Coverage 90.18899% 90.06561% -0.12338% =================================================== Files 46 46 Lines 8572 9754 +1182 =================================================== + Hits 7731 8785 +1054 - Misses 841 969 +128 ``` [see 43 files with indirect coverage changes](https://app.codecov.io/gh/Kong/ngx_wasm_module/pull/451/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Kong)
hishamhm commented 11 months ago

@thibaultcha Do you have any rules-of-thumb you've been using to decide whether a test should have Valgrind enabled? If so, perhaps it would be good idea to document them in docs/DEVELOPER.md, so we can try to apply them as well when submitting PRs.