search

Kong / ngx_wasm_module

Nginx + WebAssembly
Apache License 2.0
93 stars 8 forks source link

fix(*) fixes for ngx_wavm and ngx_proxy_wasm #462

Closed thibaultcha closed 11 months ago

thibaultcha commented 11 months ago

All fixes were uncovered one-by-one after each previous fix.

codecov[bot] commented 11 months ago

Codecov Report

Merging #462 (bed9e62) into main (69e6bf3) will increase coverage by 0.01511%. Report is 1 commits behind head on main. The diff coverage is 93.75000%.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/Kong/ngx_wasm_module/pull/462/graphs/tree.svg?width=650&height=150&src=pr&token=T0PT2Q9IAN&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Kong)](https://app.codecov.io/gh/Kong/ngx_wasm_module/pull/462?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Kong) ```diff @@ Coverage Diff @@ ## main #462 +/- ## =================================================== + Coverage 90.12645% 90.14156% +0.01510% =================================================== Files 46 46 Lines 9885 9890 +5 =================================================== + Hits 8909 8915 +6 + Misses 976 975 -1 ``` | [Files](https://app.codecov.io/gh/Kong/ngx_wasm_module/pull/462?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Kong) | Coverage Δ | | |---|---|---| | [src/common/proxy\_wasm/ngx\_proxy\_wasm\_util.c](https://app.codecov.io/gh/Kong/ngx_wasm_module/pull/462?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Kong#diff-c3JjL2NvbW1vbi9wcm94eV93YXNtL25neF9wcm94eV93YXNtX3V0aWwuYw==) | `94.18605% <100.00000%> (-0.06683%)` | :arrow_down: | | [src/wasm/vm/ngx\_wavm.c](https://app.codecov.io/gh/Kong/ngx_wasm_module/pull/462?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Kong#diff-c3JjL3dhc20vdm0vbmd4X3dhdm0uYw==) | `87.34694% <100.00000%> (+0.01724%)` | :arrow_up: | | [src/common/proxy\_wasm/ngx\_proxy\_wasm.c](https://app.codecov.io/gh/Kong/ngx_wasm_module/pull/462?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Kong#diff-c3JjL2NvbW1vbi9wcm94eV93YXNtL25neF9wcm94eV93YXNtLmM=) | `93.47319% <92.85714%> (+0.17118%)` | :arrow_up: | | [Flag](https://app.codecov.io/gh/Kong/ngx_wasm_module/pull/462/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Kong) | Coverage Δ | | |---|---|---| | [unit](https://app.codecov.io/gh/Kong/ngx_wasm_module/pull/462/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Kong) | `90.24390% <100.00000%> (+0.00224%)` | :arrow_up: | | [valgrind](https://app.codecov.io/gh/Kong/ngx_wasm_module/pull/462/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Kong) | `77.84247% <93.75000%> (+0.12454%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Kong#carryforward-flags-in-the-pull-request-comment) to find out more.
casimiro commented 11 months ago

Nice one.