search

Kong / ngx_wasm_module

Nginx + WebAssembly
Apache License 2.0
80 stars 7 forks source link

chore(ci) fix large CI workflow file #463

Closed casimiro closed 9 months ago

casimiro commented 9 months ago

This successful run demonstrates the fix.

thibaultcha commented 9 months ago

Glad that you found the root cause, awesome. How could we fix it without removing the ability to run job-build-tests.yml with different os? E.g. macos-latest in the near future?

casimiro commented 9 months ago

While addressing the issue I concluded that the problem was the single-entry bracket-list and that having more than one entry, e.g. os: [ubuntu-latest, macos-latest], wouldn't trigger the error.

But I actually haven't tested adding more entries to that list to confirm. I'll do that.

If having more items on that list also solves the issue, we can simply put the variable os back to the matrix containing ubuntu-latest and the added OS, e.g. os: [ubuntu-latest, macos-latest], when we want to add a new OS.

casimiro commented 9 months ago

The fix can be verified in this successful run.