search

Kong / ngx_wasm_module

Nginx + WebAssembly
Apache License 2.0
80 stars 7 forks source link

fix(wasmtime/macos) disable Mach integration falling back to posix signals #468

Closed casimiro closed 2 months ago

codecov[bot] commented 9 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 90.55719%. Comparing base (b28ddaa) to head (9d9d69c).

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/Kong/ngx_wasm_module/pull/468/graphs/tree.svg?width=650&height=150&src=pr&token=T0PT2Q9IAN&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Kong)](https://app.codecov.io/gh/Kong/ngx_wasm_module/pull/468?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Kong) ```diff @@ Coverage Diff @@ ## main #468 +/- ## =================================================== - Coverage 90.56638% 90.55719% -0.00919% =================================================== Files 49 49 Lines 10876 10876 =================================================== - Hits 9850 9849 -1 - Misses 1026 1027 +1 ``` | [Files](https://app.codecov.io/gh/Kong/ngx_wasm_module/pull/468?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Kong) | Coverage Δ | | |---|---|---| | [src/wasm/wrt/ngx\_wrt\_wasmtime.c](https://app.codecov.io/gh/Kong/ngx_wasm_module/pull/468?src=pr&el=tree&filepath=src%2Fwasm%2Fwrt%2Fngx_wrt_wasmtime.c&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Kong#diff-c3JjL3dhc20vd3J0L25neF93cnRfd2FzbXRpbWUuYw==) | `82.56881% <ø> (ø)` | | ... and [1 file with indirect coverage changes](https://app.codecov.io/gh/Kong/ngx_wasm_module/pull/468/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Kong) | [Flag](https://app.codecov.io/gh/Kong/ngx_wasm_module/pull/468/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Kong) | Coverage Δ | | |---|---|---| | [unit](https://app.codecov.io/gh/Kong/ngx_wasm_module/pull/468/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Kong) | `90.30837% <ø> (ø)` | | | [valgrind](https://app.codecov.io/gh/Kong/ngx_wasm_module/pull/468/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Kong) | `81.90457% <ø> (-0.04044%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Kong#carryforward-flags-in-the-pull-request-comment) to find out more.
thibaultcha commented 9 months ago

I am noticing that the tests are taking 4hrs to run this macos job... Probably what you were saying with the compiler stuff, but in any case it is unacceptably long, it should be under 30/45min at most. Perhaps we should restrict the number of tests run just like we do with Valgrind.

casimiro commented 5 months ago

The WIP label is due to the dependency on #505.

thibaultcha commented 2 months ago

It seems colima is not working on macOS 14 runners anymore. It's not installed by default anymore (see CI run). I tried installing it with brew install [docker, ...] colima on the previous line, but it didn't work either: https://github.com/Kong/ngx_wasm_module/actions/runs/9747699352/job/26901004068#step:11:215

thibaultcha commented 2 months ago

Fixed the colima thing by using macos-13 and installing the colima brew.