Kong / ngx_wasm_module

Nginx + WebAssembly
Apache License 2.0
93 stars 8 forks source link

chore(deps) fix V8 release builds #486

Closed hishamhm closed 8 months ago

hishamhm commented 9 months ago

Closes #485.

thibaultcha commented 9 months ago

It seems there still are a couple of problems as per the test run in #488?

hishamhm commented 9 months ago

@thibaultcha ah, yes, I saw the green checkmark today and undrafted this too soon. The actual test I triggered manually yesterday before calling it a night gave the same results as #488.

codecov[bot] commented 9 months ago

Codecov Report

Merging #486 (ff875f5) into main (45a0c12) will not change coverage. Report is 5 commits behind head on main. The diff coverage is n/a.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/Kong/ngx_wasm_module/pull/486/graphs/tree.svg?width=650&height=150&src=pr&token=T0PT2Q9IAN&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Kong)](https://app.codecov.io/gh/Kong/ngx_wasm_module/pull/486?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Kong) ```diff @@ Coverage Diff @@ ## main #486 +/- ## ============================================= Coverage 90.02022% 90.02022% ============================================= Files 46 46 Lines 9890 9890 ============================================= Hits 8903 8903 Misses 987 987 ``` | [Flag](https://app.codecov.io/gh/Kong/ngx_wasm_module/pull/486/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Kong) | Coverage Δ | | |---|---|---| | [unit](https://app.codecov.io/gh/Kong/ngx_wasm_module/pull/486/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Kong) | `90.08398% <ø> (ø)` | | | [valgrind](https://app.codecov.io/gh/Kong/ngx_wasm_module/pull/486/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Kong) | `77.86378% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Kong#carryforward-flags-in-the-pull-request-comment) to find out more.
hishamhm commented 8 months ago

This is ready for review/merge.

(Note that if two different branches working on release.yml trigger at the same time, you might get the wrong build container and cause a build failure — this happened to me yesterday when both @casimiro and I were doing release.yml tests)

thibaultcha commented 8 months ago

Merged in #510.