search

Kong / ngx_wasm_module

Nginx + WebAssembly
Apache License 2.0
91 stars 8 forks source link

chore(ci) drop codeql paths/paths-ignore from its config #503

Closed casimiro closed 9 months ago

casimiro commented 9 months ago

According to the GHA warning:

The "paths"/"paths-ignore" fields of the config only have effect for JavaScript, Python, and Ruby.

thibaultcha commented 9 months ago

We might have to reconfigure all of our CodeQL setup anyway, see https://github.com/github/codeql-action/issues/1179#issuecomment-1932932970 - I'm wondering if we should just drop it, so far all the noise is just for Perl libs in work/ and I can't find a way to make it shut up.

codecov[bot] commented 9 months ago

Codecov Report

Merging #503 (c76c594) into main (e9a5cf5) will not change coverage. The diff coverage is n/a.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/Kong/ngx_wasm_module/pull/503/graphs/tree.svg?width=650&height=150&src=pr&token=T0PT2Q9IAN&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Kong)](https://app.codecov.io/gh/Kong/ngx_wasm_module/pull/503?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Kong) ```diff @@ Coverage Diff @@ ## main #503 +/- ## ============================================= Coverage 90.08163% 90.08163% ============================================= Files 46 46 Lines 9800 9800 ============================================= Hits 8828 8828 Misses 972 972 ``` | [Flag](https://app.codecov.io/gh/Kong/ngx_wasm_module/pull/503/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Kong) | Coverage Δ | | |---|---|---| | [unit](https://app.codecov.io/gh/Kong/ngx_wasm_module/pull/503/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Kong) | `90.15327% <ø> (ø)` | | | [valgrind](https://app.codecov.io/gh/Kong/ngx_wasm_module/pull/503/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Kong) | `78.05940% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Kong#carryforward-flags-in-the-pull-request-comment) to find out more.