Kong / ngx_wasm_module

Nginx + WebAssembly
Apache License 2.0
80 stars 7 forks source link

chore(ci) assign unique names to uploaded artifacts #506

Closed casimiro closed 7 months ago

casimiro commented 7 months ago

Since v4, the action upload-artifact no longer supports uploading artifacts with non-unique names.

codecov[bot] commented 7 months ago

Codecov Report

Merging #506 (c340263) into main (45a0c12) will not change coverage. The diff coverage is n/a.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/Kong/ngx_wasm_module/pull/506/graphs/tree.svg?width=650&height=150&src=pr&token=T0PT2Q9IAN&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Kong)](https://app.codecov.io/gh/Kong/ngx_wasm_module/pull/506?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Kong) ```diff @@ Coverage Diff @@ ## main #506 +/- ## ============================================= Coverage 90.02022% 90.02022% ============================================= Files 46 46 Lines 9890 9890 ============================================= Hits 8903 8903 Misses 987 987 ``` | [Flag](https://app.codecov.io/gh/Kong/ngx_wasm_module/pull/506/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Kong) | Coverage Δ | | |---|---|---| | [unit](https://app.codecov.io/gh/Kong/ngx_wasm_module/pull/506/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Kong) | `90.08398% <ø> (ø)` | | | [valgrind](https://app.codecov.io/gh/Kong/ngx_wasm_module/pull/506/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Kong) | `77.86378% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Kong#carryforward-flags-in-the-pull-request-comment) to find out more.
thibaultcha commented 7 months ago

@casimiro Caio, would you mind drafting a PR that takes both @hishamhm's work in #486 and the bits from this PR? Instead of merging #486 and then rebasing this, rather rebasing this PR atop #486. I think name: release-artifacts-${{ github.job }} is a good template for all these artifacts names (combining both of your ideas). This PR also has the unit/valgrind uploads fixed and some other version bumps. Let's combine it all and enable the release job temporarily in release.yml to test it.