Kong / ngx_wasm_module

Nginx + WebAssembly
Apache License 2.0
80 stars 7 forks source link

refactor(*) proxy-wasm runloop + req state enhancements #508

Closed thibaultcha closed 7 months ago

thibaultcha commented 7 months ago

Improvements to the proxy-wasm runloop extracted from eof flag work.

codecov[bot] commented 7 months ago

Codecov Report

Merging #508 (e3f2bd8) into main (45a0c12) will decrease coverage by 0.00707%. The diff coverage is 100.00000%.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/Kong/ngx_wasm_module/pull/508/graphs/tree.svg?width=650&height=150&src=pr&token=T0PT2Q9IAN&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Kong)](https://app.codecov.io/gh/Kong/ngx_wasm_module/pull/508?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Kong) ```diff @@ Coverage Diff @@ ## main #508 +/- ## =================================================== - Coverage 90.02022% 90.01315% -0.00707% =================================================== Files 46 46 Lines 9890 9883 -7 =================================================== - Hits 8903 8896 -7 Misses 987 987 ``` | [Files](https://app.codecov.io/gh/Kong/ngx_wasm_module/pull/508?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Kong) | Coverage Δ | | |---|---|---| | [src/common/ngx\_wasm\_socket\_tcp.c](https://app.codecov.io/gh/Kong/ngx_wasm_module/pull/508?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Kong#diff-c3JjL2NvbW1vbi9uZ3hfd2FzbV9zb2NrZXRfdGNwLmM=) | `88.82759% <100.00000%> (ø)` | | | [src/common/ngx\_wasm\_subsystem.c](https://app.codecov.io/gh/Kong/ngx_wasm_module/pull/508?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Kong#diff-c3JjL2NvbW1vbi9uZ3hfd2FzbV9zdWJzeXN0ZW0uYw==) | `100.00000% <ø> (ø)` | | | [src/common/proxy\_wasm/ngx\_proxy\_wasm.c](https://app.codecov.io/gh/Kong/ngx_wasm_module/pull/508?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Kong#diff-c3JjL2NvbW1vbi9wcm94eV93YXNtL25neF9wcm94eV93YXNtLmM=) | `92.84091% <100.00000%> (+0.04090%)` | :arrow_up: | | [src/common/proxy\_wasm/ngx\_proxy\_wasm.h](https://app.codecov.io/gh/Kong/ngx_wasm_module/pull/508?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Kong#diff-c3JjL2NvbW1vbi9wcm94eV93YXNtL25neF9wcm94eV93YXNtLmg=) | `91.89189% <ø> (ø)` | | | [src/common/proxy\_wasm/ngx\_proxy\_wasm\_host.c](https://app.codecov.io/gh/Kong/ngx_wasm_module/pull/508?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Kong#diff-c3JjL2NvbW1vbi9wcm94eV93YXNtL25neF9wcm94eV93YXNtX2hvc3QuYw==) | `94.29348% <100.00000%> (ø)` | | | [src/http/ngx\_http\_wasm\_filter\_module.c](https://app.codecov.io/gh/Kong/ngx_wasm_module/pull/508?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Kong#diff-c3JjL2h0dHAvbmd4X2h0dHBfd2FzbV9maWx0ZXJfbW9kdWxlLmM=) | `92.73743% <100.00000%> (-0.15874%)` | :arrow_down: | | [src/http/ngx\_http\_wasm\_module.c](https://app.codecov.io/gh/Kong/ngx_wasm_module/pull/508?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Kong#diff-c3JjL2h0dHAvbmd4X2h0dHBfd2FzbV9tb2R1bGUuYw==) | `96.00939% <100.00000%> (ø)` | | | [src/http/proxy\_wasm/ngx\_http\_proxy\_wasm.c](https://app.codecov.io/gh/Kong/ngx_wasm_module/pull/508?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Kong#diff-c3JjL2h0dHAvcHJveHlfd2FzbS9uZ3hfaHR0cF9wcm94eV93YXNtLmM=) | `93.51351% <100.00000%> (-0.06939%)` | :arrow_down: | | [src/http/proxy\_wasm/ngx\_http\_proxy\_wasm\_dispatch.c](https://app.codecov.io/gh/Kong/ngx_wasm_module/pull/508?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Kong#diff-c3JjL2h0dHAvcHJveHlfd2FzbS9uZ3hfaHR0cF9wcm94eV93YXNtX2Rpc3BhdGNoLmM=) | `91.22807% <100.00000%> (ø)` | | | [src/wasm/ngx\_wasm.h](https://app.codecov.io/gh/Kong/ngx_wasm_module/pull/508?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Kong#diff-c3JjL3dhc20vbmd4X3dhc20uaA==) | `100.00000% <ø> (ø)` | | | ... and [1 more](https://app.codecov.io/gh/Kong/ngx_wasm_module/pull/508?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Kong) | | | [Flag](https://app.codecov.io/gh/Kong/ngx_wasm_module/pull/508/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Kong) | Coverage Δ | | |---|---|---| | [unit](https://app.codecov.io/gh/Kong/ngx_wasm_module/pull/508/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Kong) | `90.07941% <100.00000%> (-0.00458%)` | :arrow_down: | | [valgrind](https://app.codecov.io/gh/Kong/ngx_wasm_module/pull/508/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Kong) | `77.84173% <100.00000%> (-0.02206%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Kong#carryforward-flags-in-the-pull-request-comment) to find out more.