search

Kong / openresty-patches

Moved to https://github.com/Kong/kong-build-tools
Apache License 2.0
14 stars 6 forks source link

feat(*) add travis-ci integration #22

Closed bungle closed 6 years ago

bungle commented 6 years ago

Adds Travis CI integration to this repository.

james-callahan commented 6 years ago

How do we plan to keep the script updated in future?

One idea I had was to simply clone kong and use the script from there directly; that way there is only one source of truth.

bungle commented 6 years ago

@james-callahan, we will need to update it when something in kong repo changes, or when we have new release for OpenResty. Though when new release of OpenResty comes we need to add patches too, so bumping .ci could be done the same time.

I though about reusing the script of Kong repo directly, but decided to skip it for now. I think we need to come up with more modular travis-ci integration to make it truly reusable in different contexts. I thought about using this too: https://github.com/Kong/kong-ci (but that is already lacking behind what is in Kong repo, e.g. doesn't apply patches etc.), and it was more geared to plugin testing. @hutchic might want to have his say about that?

Yes, I am bit worried about having yet another repo copy-pasting scripts from other repo and then slightly modifying them. But well, this repo is rather static compared to other repos. So let's start with what I have here now, and maybe take a broader view of this issue later.