search

Kong / unirest-java

Unirest in Java: Simplified, lightweight HTTP client library.
http://kong.github.io/unirest-java/
MIT License
2.6k stars 592 forks source link

Please provide a rebuild of version 3.1.02 #311

Closed JoHaHu closed 4 years ago

JoHaHu commented 4 years ago

The org.apache.httpcomponents:httpasyncclient:4.1.4 library that unirest depends on has fixed a bug in httpcore-nio where automatic module name resolution in java 9 and above fails, because they uses an invalid module identifier. Please provide a rebuild of this library. There is no need to change any version number of any library because httpasyncclient fixed it with same version number. Otherwise a new version with fixed libray is appreciated aswell.

Thank you!

JoHaHu commented 4 years ago

Sorry they didnt fixed. it my bad.

ryber commented 4 years ago

Do you have a link to the issue in their issue tracker (I think it's Jira?)

JoHaHu commented 4 years ago

https://issues.apache.org/jira/browse/HTTPCORE-533

They fixed httpcore-nio, but they didnt fixed their httpasyncclient that uses that library

ryber commented 4 years ago

It's possible we can simply declare our own dependency on httpcore-nio and override 4.4.10

JoHaHu commented 4 years ago

That would be nice. It's my current workaround at the moment.

JoHaHu commented 4 years ago

I can confirm that the new version fixes my issue. Therefore I am closing this.