search

Kong / unirest-java

Unirest in Java: Simplified, lightweight HTTP client library.
http://kong.github.io/unirest-java/
MIT License
2.59k stars 593 forks source link

Remove redundant dependencies #400

Closed Celebrate-future closed 3 years ago

Celebrate-future commented 3 years ago

@ryber Hi, I am a user of project com.kong:bad-maven-test:2.3.00-SNAPSHOT. I found that its pom file introduced 10 dependencies. However, among them, 8 libraries (80%) have not been used by your project (the redundant dependencies are listed below). Reduce these useless dependencies can help prevent conflicts between library versions. MeanWhile, it can minimize the total added size to projects. It can also help enable advanced scenarios for users of your package. This PR helps com.kong:bad-maven-test:2.3.00-SNAPSHOT lose weight :) I have tested the revised configuration in my local environment. It is safe to remove the unused libraries.

Best regards

Redundant dependencies----


commons-logging:commons-logging:jar:1.2:compile
org.apache.httpcomponents:httpcore:jar:4.4.11:compile
commons-codec:commons-codec:jar:1.11:compile
org.apache.httpcomponents:httpmime:jar:4.5.8:compile
org.apache.httpcomponents:httpasyncclient:jar:4.1.4:compile
org.apache.httpcomponents:httpclient:jar:4.5.8:compile
org.apache.httpcomponents:httpcore-nio:jar:4.4.10:compile
org.json:json:jar:20180813:compile
CLAassistant commented 3 years ago

CLA assistant check
All committers have signed the CLA.

ryber commented 3 years ago

the pom that was modified is not the main project pom, it's actually a test pom for exposing and testing various pom problems with packaging and so is wrong on purpose.