Kong / unirest-nodejs

Unirest in Node.js: Simplified, lightweight HTTP client library.
http://unirest.io/nodejs
MIT License
951 stars 167 forks source link

Make unirest compatible to mime 2.* versions #129

Open gayathridmallela opened 4 years ago

gayathridmallela commented 4 years ago

This is to support the higer versoin of mime from 2.* .This fix is required to avoid the error of mandate true on the mine on the retries

To avoid the below error on retries callback

Error: Attempt to change mapping for "form" extension from "application/x-www-form-urlencoded" to "application/x-www-form-urlencoded". Pass force=true to allow this, otherwise remove "form" from the list of extensions for "application/x-www-form-urlencoded". at Mime.define (/home/user/projects/mytest/node_modules/mime/Mime.js:32:17)

crispinkoech commented 4 years ago

Hey, any update on this? Facing this issue on one of our packages 😅 @nijikokun

nijikokun commented 4 years ago

Appears that one of the tests is failing, once resolved I can merge

CLAassistant commented 3 years ago

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.