Apply encodeUrl only when body is passed.

Kong / unirest-php

Unirest in PHP: Simplified, lightweight HTTP client library.

http://unirest.io/php

MIT License

1.28k stars 328 forks source link

Apply encodeUrl only when body is passed. #133

Open prasad83 opened 6 years ago

prasad83 commented 6 years ago

Query part can be constructed in the following manner into the URL:

$url . '?' . http_build_query($body); / uses PHP_QUERY_RFC1738 /
$url . '?' . http_build_query($body, null, ini_get('arg_separator.output'), PHP_QUERY_RFC3986);

So when no $body is set - incoming $url should be assumed pre-built as required.

CLAassistant commented 3 years ago

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
_{You have signed the CLA already but the status is still pending? Let us recheck it.}