Closed stevenkaras closed 10 years ago
You're right - can you submit a pull request? That would help a lot.
Soonest I can get around to it is this weekend.
I think the best fix is to restrict the rescue to only RestClientExceptions, so it catches the status code exceptions, but allows underlying socket errors/getaddrinfo errors to bubble up.
Hey @stevenkaras just checking in if you were able to contribute to this issue.
You guys already merged the commit that fixes the issue. Forgot to write the issue number in the commit message, otherwise this would already be closed.
99f66f106719e93ed5117fae7325e78aa73f026d
Oh! Thanks!
On Ubuntu 1304/rvm/MRI 2.1, the following code results in a NoMethodError:
The internal SocketError should probably be raised up, or should mark the response as an error. I'm unsure of the intended behavior, otherwise I'd fork and fix.