search

KongMD-Steam / QuestionableEthicsEnhanced

The source code of the Questionable Ethics Enhanced mod for RimWorld.
MIT License
12 stars 7 forks source link

Genome template stacking doesn't check name in equality test #59

Closed KongMD-Steam closed 5 years ago

KongMD-Steam commented 5 years ago

Describe the bug When the game checks whether Genome Template X can stack with GenomeTemplate Y, it will always stack it if all stored values are the same except for the name of the person/animal that the template was generated from. Practical example:

Before game checks stack compatibility:

Jenny genome template
JennysClone genome template

After a pawn re-organizes the stacks:

Jenny genome template x2

Expected behavior Only templates that are exactly the same stack.

To Reproduce Steps to reproduce the behavior:

  1. Create a zone for genome templates only
  2. Create a genome template from Jenny
  3. Clone Jenny and debug finish. Name new clone JennysClone
  4. Create a genome template from JennysClone
  5. Observe that a pawn will move the JennysClone genome template to the stack with Jenny's template, resulting in a single stack of two Jenny genome templates.

Additional Info If the Jenny and JennysClone have different skills, the templates will not stack. All stored values must be the same except the name, for this bug to happen.