search

KongMD-Steam / QuestionableEthicsEnhanced

The source code of the Questionable Ethics Enhanced mod for RimWorld.
MIT License
12 stars 7 forks source link

Organ Vat recipes break when ingredient count > MaxStackSize #93

Closed KongMD-Steam closed 4 years ago

KongMD-Steam commented 4 years ago

Describe the bug RecipeDefs that include ingredients with greater than the size of a single stack cause the AI programming that loads the Organ Vat to break. Pawns will only load up to the amount in one full stack of the ingredient. Example: If a recipe calls for 200 Nutrient Solution, only 150 Nutrient Solution will be loaded into the vat.

NOTE: This does not affect the default organ vat recipe values in QEE, as none of them need more than a full stack of Nutrient Solution or Protein Mash to complete. It was discovered during development of the Evolved Organs mod.

Expected behavior Any amount of an ingredient can be used and processed correctly by the Organ Vat during the vat loading process.

To Reproduce Steps to reproduce the behavior:

  1. In Recipes_OrganVat.xml, change the 'QE_NaturalOrganGrowerRecipeBase' to have Nutrient Solution of 200.
  2. Attempt to grow a Natural Arm
  3. Observe that pawns will only load 150 Nutrient Solution into the vat. They will never load the last 50.

Additional context Thank you to Xahkarias for reporting this bug.

KongMD-Steam commented 4 years ago

Fixed in commit 45f2912291ba4d29a67724b0346a104b3aff71c1.