Koniverse / SubWallet-Extension

SubWallet is the comprehensive non-custodial wallet solution for Polkadot, Substrate & Ethereum ecosystems.
https://www.subwallet.app
Apache License 2.0
93 stars 66 forks source link

Extension - Add validate account in case sign transaction with Ledger account #3263

Closed ThaoNguyen998 closed 2 months ago

ThaoNguyen998 commented 3 months ago

Describe the task Add validate account in case sign transaction with Ledger account

Expect: Show message on confirmation: "Wrong device. Connect your previously used Ledger and try again"

haiyenvu23 commented 3 months ago

Version test : http://14.224.129.242:8900/s/DgK8ZwADWBss7BS

haiyenvu23 commented 3 months ago

Version test : http://14.224.129.242:8900/s/DseLF3PQNcSiw4z

Image

haiyenvu23 commented 2 months ago

Version test : http://14.224.129.242:8900/s/p6n3GRZ8crWSaJR

Image

Image

Expect :

Image

haiyenvu23 commented 2 months ago

Re-check with cases :

  • Attach account with ledger A but sign with ledger B

  • Check when changing back to ledger ( choose same network )

  • Check when changing back to ledger but choosing another network

  • Check when not connected to ledger

  • Re-check with normal account

  • Attach account with ledger A but sign with ledger B

  • Check when changing back to ledger ( choose same network )

  • Check when changing back to ledger but choosing another network

  • Check when not connected to ledger

  • Re-check with normal account

  • Attach account with ledger A but sign with ledger B

  • Check when changing back to ledger ( choose same network )

  • Check when changing back to ledger but choosing another network

  • Check when not connected to ledger

  • Re-check with normal account

haiyenvu23 commented 2 months ago

Version test :

Validation passed in case :

Image

Attach account with ledger A but sign with ledger B

Image

Image

Image

Check when changing back to ledger ( choose same network )

Image

Check when changing back to ledger but choosing another network

Image

The error occurs when there is a communication issue between the device and the ledger.

Image

Image

Check when not connected to ledger => Related to issue https://github.com/Koniverse/SubWallet-Extension/issues/2568#issuecomment-2222026299

Screenshot (811) The error occurs when there is a communication issue between the device and the ledger.

Image The error occurs when the ledger cannot be detected for connection.

image The error occurs when the ledger disconnects or actively terminates the connection to the device.

Re-check with normal account