Support staking for more chains

RyanDinh8 commented 2 years ago

Is your feature request related to a problem? Please describe.

Please add the staking button for the following parachains

[x] Moonbeam/Moonriver
[x] Polkadex
[x] Turing Network
[x] Astar dApp staking
[x] Bifrost

nampc1 commented 2 years ago

Networks with special staking mechanism:

Acala Acala offers liquid staking for DOT. Users will receive LDOT which represents the amount of DOT staked to use elsewhere. Acala liquid staking requires 5 DOT minimum for staking and allows instant unstaking.
Bifrost Firstly, users must transfer KSM to Bifrost Parachain with XCM. Then users initiate a vKSM mint order with KSM. Users can use vKSM in dApp and Defi protocols on DotSama
Khala/Phala Users delegate to a stake pool which is owned by an on-chain account. Then the stake pool stakes the workers and start mining. The stake pool has limited capacity. Users must claim tokens manually.
Kintsugi/Interlay Users can stake KINT or INTR (native tokens) to receive vKINT or vINTR as rewards. Staking requires a certain locking period (no flexible staking). The locking duration is per account (different mechanisms to other chains). The locking duration can be extended.
Darwinia Darwinia has a 2-tokens staking mechanism. Users can stake RING (native token) in 2 ways: flexible or locked staking. Flexible staking works like other chains with an unlocking period when unbonding. Locked staking requires user to lock RING for a certain amount of time. User will receive the KTON token as the staking reward. User can only unbond before the locked time if user slashes x3 amount of KTON. Finally, both RING and KTON can be used to stake (together or individually). The reward that users receive is proportionate to the total of RING and KTON (known as POWER).
Lido Lido is a liquid staking protocol originally from Ethereum, now on MoonBeam and MoonBase Alpha. To start staking DOT or KSM, user needs to transfer KSM or DOT to MoonBeam with xcm to receive xcKSM, then interact with Lido smart contract to stake. Users will receive stKSM (pegged 1:1 to xcKSM) as the representative of their stake position. stKSM can be exchanged back to xcKSM. Difficulties: transferring with XCM, interacting with an EVM smart contract, showing stKSM

sokol142 commented 2 years ago

[x] Do not showing Amount when user click on unstake all button for the Account Substrate
[x] Not found transaction history in case of staking, unstaking & withdrawal for the Moonbase Alpha chain

sokol142 commented 2 years ago

Version test: https://file.cdmteck.com/s/4oimk9zDJ8R5Aai/download?path=%2F&files=./399-merge-build-0.4.9-1656923068816.zip

Bugs

[x] Can not view all network to staking

[x] Can not staking for Validator that have Minimum stake = 0
[x] Still enable Amount in case user tick on Unstake all
[x] Can not unstake for EVM Account
[x] Can not claim reward

Improvement

[x] Convert Dapp's avatar into circle
[x] Hide expected return in case expected return = 0
[x] Redirect to the List Staking when user switch account Steps:
1. Open the expand extension
2. Switch to any EVM Account
3. Open the staking tab
4. Go to the Select Validator/Staking action screen...
5. Open the popup extension
6. Switch Account to any Substrate Account
7. Observe information displayed on the expand extension Actual: Information is incorrect Expected: Redirect to the List Staking when user switch account

sokol142 commented 2 years ago

Version test: https://file.cdmteck.com/s/4oimk9zDJ8R5Aai/download?path=%2F&files=./399-merge-build-0.4.9-1657179143656.zip Please check:

Bugs

[x] Still can not staking for Validator that have Minimum stake = 0
Example: To reproduce with Turing Stage Network, observe in here: https://www.loom.com/share/4cf733ef96da467898559e8c056b1698
[x] An error occurred the user unstake SBY token when the transaction was incomplete (To reproduce the bug, observe in here: https://www.loom.com/share/220fd1a388904f77960700387599318e)
[x] Amount Unstaking is incorrect in case of multiple unstake
Actual: Total Stake = 10.5 SBY but when click on unstake all then Total Unstake = 15.5 SBY (Validator 1: 5.5 SBY, Validator 2: 10 SBY) To reproduce the bug, observe in here: https://www.loom.com/share/6b69506a17ea40d8a7073322feca36a1 => Re- check: Incorrect value in case of unstake SBY (input unstake 2 SBY but stake value = 5 after submit successfully): https://www.loom.com/share/aa91ec41e8a94663bd95c10657f0b86c
[x] Can not withdraw for EVM Chain
[x] Please checking the reward request error again, I only get the reward the first time, the next time get the reward is infinity loading

Improvements

[x] Disable button Cancel and Select box when extension is loading
[x] Clear default value for the Amount field on the Unstake screen
[x] Redirect to the List Staking or Select Network when user disconnect network

sokol142 commented 2 years ago

[x] Showing message "Your balance is too low to cover fees" even though have enough balance to cover fees Pre-condition:
Account A have balance < 0.2 WND
Have stake record for the Account A Steps:
1. Open the extension then switch to Account A
2. Go to the unstake screen
3. Input valid data for the all fields then click button Confirm
4. Observe result Actual: Showing message "Your balance is too low to cover fees" but still unstake successfully (stake balance is decreasing, & unstake balance is increasing): https://www.loom.com/share/890a8c2cfebf44e0802d18d87abbaec8
[x] Incorrect amount when user click on unstake all with small amount Solution: manual input
Select unstake all -> improve later: https://github.com/Koniverse/SubWallet-Extension/issues/471

sokol142 commented 2 years ago

Version test: https://file.cdmteck.com/s/4oimk9zDJ8R5Aai/download?path=%2F&files=./399-merge-build-0.4.9-1657618719858.zip

Please check issues:

[x] Still can not withdraw for EVM Chain
[x] Incorrect value in case of unstake SBY (input unstake 2 SBY but stake value = 5 after submit successfully): https://www.loom.com/share/aa91ec41e8a94663bd95c10657f0b86c
[x] Showing incorrect tooltip when hover to Claim Reward button
[x] The Next button is disabled in case Change DApp/Validator
[x] Bug happens when user claim reward
Case 1: Click on Claim Reward button
Case 2: Not showing selected DApp in case change DApp (Change form Algem to ADAO but still display Algem)

sokol142 commented 2 years ago

Version test: https://file.cdmteck.com/s/4oimk9zDJ8R5Aai/download?path=%2F&files=./399-merge-build-0.4.9-1657773379198.zip

Please check some issue

[x] An error occurred when the user unstakes after a few minutes of successful staking (with Astar dApp staking Shibuya Testnet)

Steps:

Open the extension
Staked for Shibuya Testnet successfully
Perform claim reward successfully
Then, click on Unstake fund action

Actual: An error occurred 399_unstake_2

[x] Showing incorrect unstaking value Pre-condition: Previously unstake was successful
Example: Staked & unstake for dApp = ADAO successfully with 6 SBY

Steps:

Open the extension
Staked on Shibuya Testnet Network for dApp = Algem successfully with 5 SBY
Perform claim reward successfully
Then, click on Unstake fund action
Click on dApp dropdown then observe list dApp showing
Click on Unstake All then observe unstake amount

Actual:

Step 5: Not showing Algem dApp
Step 6: Amount = 6 SBY while only 5 SBY
[x] Claim Reward button displayed is disable when Active stake = 0 (with Astar dApp staking Shibuya Testnet)
[x] Showing incorrect amount staking in the case of opening the unstake screen and there is only 1 validator (see file below) - Notes: Don't select collator
[x] Not update list validator on the unstake screen in case of multiple validators

Steps:

Stake for Validator A: 5 & Validator B: 6
Unstake for Validator A: 5 (unstake all)
Go to unstake screen again, then click on Select a validator dropdown to check list validator display

Actual:

Turing Stage: Not update list validator, still display Validator A on list
Moonbase: still display Validator A on list; Only update list validator when switch account or perform another transaction successfully

Improvements
[x] Update UX when user enters decimal to set amount unstaking
[x] Update UI for nominating mark
Expected: When user unstake then the validator will lose the nominating mark

sokol142 commented 2 years ago

Staking feature over view

sokol142 commented 2 years ago

Version test: https://file.cdmteck.com/s/4oimk9zDJ8R5Aai/download?path=%2F&files=./399-merge-build-0.4.9-1658137687379.zip

[x] Can not unstake for Relaychain
[x] Re-check bug: Showing incorrect amount staking in the case of opening the unstake screen and there is only 1 validator
[x] Showing incorrect information when the transactions is loading
[x] The validator not mark the nomination icon after stake successful (for parachain)

sokol142 commented 2 years ago

Version test: https://file.cdmteck.com/s/4oimk9zDJ8R5Aai/download?path=%2F&files=./399-merge-build-0.4.9-1658215640492.zip Please check issue:

[x] Update UX when user enters decimal to set amount unstaking for relaychain
[x] Update tooltip when user hover over claim reward button
Change to "Make sure you claim all rewards regularly and before you unstake"
[x] Kindly check rounding function

sokol142 commented 2 years ago

Version test: https://file.cdmteck.com/s/4oimk9zDJ8R5Aai/download?path=%2F&files=./399-merge-build-0.4.9-1658227070767.zip

[x] Incorrect withdrawable value display after successful withdrawal: https://www.loom.com/share/041ec9a66da14427a6374e35dea4e252
[x] Recheck the withdrawal function for the Turing network

sokol142 commented 2 years ago

Version test: https://file.cdmteck.com/s/4oimk9zDJ8R5Aai/download?path=%2F&files=./399-merge-build-0.4.9-1658400401295.zip

Bugs

[x] Can not withdraw for Bifrost
[x] Recheck the all function for the Shibuya Testnet network (include: stake, unstake, withdraw, claim reward, nominating mark)