Implement Wallet Connect - Githubissues

Koniverse / SubWallet-Mobile

SubWallet is the comprehensive non-custodial wallet solution for Polkadot, Substrate & Ethereum ecosystems

Apache License 2.0

30 stars 29 forks source link

Implement Wallet Connect #281

Closed lw-cdm closed 9 months ago

lw-cdm commented 1 year ago

Implement Wallet Connect following what implemented on extension (https://github.com/Koniverse/SubWallet-Extension/issues/1497):

[x] Implement scanner
[x] Implement deep-link

Detail:

Component:
[x] Dual Logo (change the center icon for WalletConnect confirmation)
[x] WCAccountSelect
[x] WCNetworkSelect
[x] WCNetworkSupported
[x] WCAvatarGroup
Screen:
[x] ConnectList
[x] ConnectWalletConnect
[x] ConnectDetail
[x] WalletConnectConfirmation
[x] ScanToConnectWalletConnect

Sokol142196 commented 10 months ago

Version test: https://file.cdmteck.com/s/DB9JLAnjJczopcC/download?path=%2F&files=SubWalletMobile-build-203-911-merge-2023-07-21T09-38-39.ipa

Please check:

[x] Can not connect WalletConnect in case support both Substrate & EVM network
- Actual: Do not show select account field

[x] Still displaying submitting after connecting failed in case connection exists

[x] UI bugs

Case: connect app to app

[x] Still show "invalid URI" when sign transaction
[x] Show "connect exists" when connect WalletConnect on the first time
[x] Handle case connect WalletConnect when do not create master password yet
- Steps:
  1. Install SubWallet
  2. Go to the dApp (support connect by WalletConnect via deeplink)
  3. On the dApp, click connect with SubWallet
  4. Observe the screen displaed in SubWallet
- Actual: Show the approve request (create one account to connect) but do not create account cause do not create master password
- Expect: If user do not create master password yet, when click on "Create one" button then navigate user to the create master password

Sokol142196 commented 10 months ago

Version test: https://file.cdmteck.com/s/DB9JLAnjJczopcC/download?path=%2F&files=SubWalletMobile-build-204-911-merge-2023-07-27T06-13-58.ipa

Please check issues:

[x] Do not show the popup confirmation when opening modal (Scan QR code, Receive addess...)

Reproduce the behavior Pre-condition: Connect with WallectConnect successfully

Steps:
1. Open the app
2. Go to the Select token to get the address or Scan QR code...
3. On the dApp, send a request to SubWallet (sign request)
4. Observe the SubWallet
Actual: Do not show popup confirmation
- And: Do not redirect when accessing to Setting menu or browser
[x] UI bug when have multiple accounts on list

[x] Do not show err message in case connect to ConnectWallet is failed when scanning from the Setting screen
- Actual: Back to Setting screen then show err message
- Expect: Show error message on the Scan QR code screen
[x] Redirect incorrect screen when click Back on the scan QR from Setting screen in case have connection
- Actual: Back to Setting screen
- Expect: Back to List connection screen
Show popup confirmation in case not support method (follow the issue: https://github.com/Koniverse/SubWallet-Extension/issues/1674) => improve later

Sokol142196 commented 10 months ago

Version test: https://file.cdmteck.com/s/DB9JLAnjJczopcC/download?path=%2F&files=SubWalletMobile-build-204-911-merge-2023-07-29T11-10-45.ipa

Please check:

[x] Handle case camera access permission
- Actual: If user select denied permission then can not use app continuing

[x] Do not navigate in case modal overlap modal on iOS device Steps:
1. Open the SubWallet app
2. Connect to dApp via WalletConnect successfully
3. On the SubWallet app, go to the History detail or QR code screen
4. On the dApp, perform any transaction
5. On the SubWallet app: approve transaction then navigate to the other screen
Actual: Do not navigate

https://github.com/Koniverse/SubWallet-Mobile/assets/130966515/804af487-c164-4ec2-a638-d9c9ec01fb4d

=> Solution: Hot fixed before then fixed this issue in https://github.com/Koniverse/SubWallet-Mobile/issues/928

ThaoNguyen998 commented 10 months ago

Version test: https://file.cdmteck.com/s/DB9JLAnjJczopcC/download?path=%2F&files=SubWalletMobile-build-205-911-merge-2023-08-07T02-44-00.apk Device test: MI 8 Lite

[x] Do not show confirmation when connect wallet
[x] Navigate incorrect screen Pre-condition:
Enable Pin code feature
App lock = Immediately Steps:
1. Open the Welcome back screen
2. Perform forget all account and observe the displayed screen
3. Close app and re-open app

Actual: https://share.icloud.com/photos/082HaP_Vf3WE9Mc2QxF1cRbJQ In step 2: Do not show Welcome screen In step 3: Show Welcome screen

[x] Flash Wallet connect screen

https://github.com/Koniverse/SubWallet-Mobile/assets/117999489/0a903fe4-aa3d-444c-b683-36591979d6e4

[x] Skip auto focus Search in case open Wallet connect list screen

ThaoNguyen998 commented 9 months ago

Version test: https://file.cdmteck.com/s/DB9JLAnjJczopcC/download?path=%2F&files=SubWalletMobile-build-205-911-merge-2023-08-08T12-30-11.apk

[x] Modal overlapped modal in case connect wallet

ThaoNguyen998 commented 9 months ago

Version test: https://file.cdmteck.com/s/DB9JLAnjJczopcC/download?path=%2F&files=SubWalletMobile-build-205-911-merge-2023-08-10T09-38-11.ipa Devices test: IP 11 Validation passed.